Genesis upgrade and add invariant cherry pick #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #1081 +/- ##
==========================================
+ Coverage 20.64% 20.75% +0.11%
==========================================
Files 193 194 +1
Lines 25270 25318 +48
==========================================
+ Hits 5218 5256 +38
- Misses 19096 19102 +6
- Partials 956 960 +4
Continue to review full report at Codecov.
|
ValarDragon
reviewed
Mar 13, 2022
Comment on lines
+91
to
+96
| func (h Hooks) AfterValidatorSlashed(ctx sdk.Context, valAddr sdk.ValAddress, infractionHeight int64, slashFactor sdk.Dec, effectiveSlashFactor sdk.Dec) { | ||
| if slashFactor.IsZero() { | ||
| return | ||
| } | ||
| h.k.RefreshIntermediaryDelegationAmounts(ctx) | ||
| } |
There was a problem hiding this comment.
We can't backport this PR due to this change. We do need to get the export genesis changes onto v7.x though. Eugen can you make a PR to v7.x with the import / export genesis changes?
There was a problem hiding this comment.
Actually I'll just have the bot open that PR, and we just comment out these lines
ValarDragon
reviewed
Mar 13, 2022
Comment on lines
+27
to
+50
| // { | ||
| // "with single validator and multiple superfluid delegations", | ||
| // []stakingtypes.BondStatus{stakingtypes.Bonded}, | ||
| // 2, | ||
| // []superfluidDelegation{{0, 0, 0, 1000000}, {1, 0, 0, 1000000}}, | ||
| // []int64{0}, | ||
| // []int64{0, 1}, | ||
| // }, | ||
| // { | ||
| // "with multiple validators and multiple superfluid delegations with single validator slash", | ||
| // []stakingtypes.BondStatus{stakingtypes.Bonded, stakingtypes.Bonded}, | ||
| // 2, | ||
| // []superfluidDelegation{{0, 0, 0, 1000000}, {1, 1, 0, 1000000}}, | ||
| // []int64{0}, | ||
| // []int64{0}, | ||
| // }, | ||
| // { | ||
| // "with multiple validators and multiple superfluid delegations with two validators slash", | ||
| // []stakingtypes.BondStatus{stakingtypes.Bonded, stakingtypes.Bonded}, | ||
| // 2, | ||
| // []superfluidDelegation{{0, 0, 0, 1000000}, {1, 1, 0, 1000000}}, | ||
| // []int64{0, 1}, | ||
| // []int64{0, 1}, | ||
| // }, |
There was a problem hiding this comment.
We'll need to fix these tests in an upcoming PR
ValarDragon
approved these changes
Mar 13, 2022
ValarDragon
added
the
A:backport/v7.x
mergify bot
pushed a commit
that referenced
this pull request
Mar 13, 2022
* add TotalSuperfluidDelegationInvariant * update invariant name * Update x/superfluid/keeper/invariants.go Co-authored-by: Dev Ojha <[email protected]> * Update x/superfluid/keeper/invariants.go Co-authored-by: Dev Ojha <[email protected]> * revert back changes for SetLockIdIntermediaryAccountConnection * convert to round * add invariant checker function call on all superfluid tests * update go mod/sum * add after validator slashed hook * following updates for main branch cherry-pick Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit a454116) # Conflicts: # go.sum # x/superfluid/keeper/slash_test.go
ValarDragon
pushed a commit
that referenced
this pull request
Mar 15, 2022
* Genesis upgrade and add invariant cherry pick (#1081) * add TotalSuperfluidDelegationInvariant * update invariant name * Update x/superfluid/keeper/invariants.go Co-authored-by: Dev Ojha <[email protected]> * Update x/superfluid/keeper/invariants.go Co-authored-by: Dev Ojha <[email protected]> * revert back changes for SetLockIdIntermediaryAccountConnection * convert to round * add invariant checker function call on all superfluid tests * update go mod/sum * add after validator slashed hook * following updates for main branch cherry-pick Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit a454116) # Conflicts: # go.sum # x/superfluid/keeper/slash_test.go * resolve conflicts Co-authored-by: antstalepresh <[email protected]> Co-authored-by: antstalepresh <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer